fix: null in openapi enums breaks client generation BNCH-32257
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI specifies that if an enum is nullable, to specify - null in the list of possible items. This manifests as None when parsed in Python, and the parser tries to create a member in the enum class for it. This fails because it attempts to convert it to uppercase, and it's not a string, but None shouldn't get an enum value NULL or NONE anyway, because the client code would just pass None instead of EnumProperty.NONE for a nullable enum.
This change makes a change to support empty strings as well, mirroring the fix in upstream: https://github.com/openapi-generators/openapi-python-client/pull/358/files